Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing word in frameError event docs #28387

Merged
merged 1 commit into from
Jun 24, 2019
Merged

doc: add missing word in frameError event docs #28387

merged 1 commit into from
Jun 24, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jun 22, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Jun 22, 2019
Trott
Trott approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: What's with the odd "an attempt to emit" phrasing here? Is the idea that the event might not actually be emitted?

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 24, 2019

Aside: What's with the odd "an attempt to emit" phrasing here? Is the idea that the event might not actually be emitted?

It looks like the event should be emitted, but I didn't write the original docs, so I'm not 100% sure what the intention was. I guess there is always the possibility that the stream has been destroyed.

@cjihrig
Copy link
Contributor Author

cjihrig commented Jun 24, 2019

Green Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3711/

@cjihrig
doc: add missing word in frameError event docs
ad4d626 
PR-URL: nodejs#28387
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit ad4d626 into nodejs:master Jun 24, 2019
@cjihrig cjihrig deleted the typo branch June 24, 2019 22:13
targos pushed a commit that referenced this pull request Jul 2, 2019
@cjihrig @targos
doc: add missing word in frameError event docs
0e6196c 
PR-URL: #28387
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jul 2, 2019
Merged
This was referenced Jul 3, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @jasnell @Trott @antsmartian @lpinca @trivikr @nodejs-github-bot